CTTY commented on code in PR #1600:
URL: https://github.com/apache/iceberg-rust/pull/1600#discussion_r2277551340
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -152,11 +174,52 @@ impl TableProvider for IcebergTableProvider {
fn supports_filters_pushdown(
&self,
filters: &[&Expr],
- ) -> std::result::Result<Vec<TableProviderFilterPushDown>,
datafusion::error::DataFusionError>
- {
+ ) -> DFResult<Vec<TableProviderFilterPushDown>> {
// Push down all filters, as a single source of truth, the scanner
will drop the filters which couldn't be push down
Ok(vec![TableProviderFilterPushDown::Inexact; filters.len()])
}
+
+ async fn insert_into(
+ &self,
+ _state: &dyn Session,
+ input: Arc<dyn ExecutionPlan>,
+ _insert_op: InsertOp,
+ ) -> DFResult<Arc<dyn ExecutionPlan>> {
+ if !self
+ .table
Review Comment:
Ideally we should refresh the table here and every other`self.table` usages
in `IcebergTableProvider`, but I think we should fix that in a separate PR if
needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
