CTTY commented on code in PR #1600:
URL: https://github.com/apache/iceberg-rust/pull/1600#discussion_r2283233669
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -140,8 +152,15 @@ impl TableProvider for IcebergTableProvider {
filters: &[Expr],
_limit: Option<usize>,
) -> DFResult<Arc<dyn ExecutionPlan>> {
+ // Refresh table if catalog is available
+ let table = if let Some(catalog) = &self.catalog {
+
catalog.load_table(self.table.identifier()).await.map_err(to_datafusion_error)?
+ } else {
+ self.table.clone()
+ };
+
Review Comment:
Hi @phillipleblanc , thanks for pointing me to your change! Your change
makes sense to me, but I was thinking of adding something like this to `impl
Table` directly
```
pub async fn refresh(&mut self, catalog: &dyn Catalog) -> Result<Self>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
