stevenzwu commented on code in PR #13804:
URL: https://github.com/apache/iceberg/pull/13804#discussion_r2278177430
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestFilterPushDown.java:
##########
@@ -578,6 +578,28 @@ public void
testFilterPushdownWithSpecialFloatingPointPartitionValues() {
ImmutableList.of(row(4, Double.NEGATIVE_INFINITY)));
}
+ @TestTemplate
+ public void testFilterPushdownWithRequiredNestedFieldInOptionalStruct() {
+ sql(
+ "CREATE TABLE %s (id INT NOT NULL, address STRUCT<street: STRING NOT
NULL>)"
+ + "USING iceberg ",
+ tableName);
+ configurePlanningMode(planningMode);
+
+ sql("INSERT INTO %s VALUES (0, NULL)", tableName);
+ sql("INSERT INTO %s VALUES (1, STRUCT('123 Main St'))", tableName);
+
+ checkOnlyIcebergFilters(
+ "address is null" /* query predicate */,
Review Comment:
we should also test predicate on nested field, right? that is what this PR
tries to fix.
```
address.street is null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
