huaxingao commented on code in PR #13804:
URL: https://github.com/apache/iceberg/pull/13804#discussion_r2280123433
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestFilterPushDown.java:
##########
@@ -578,6 +578,28 @@ public void
testFilterPushdownWithSpecialFloatingPointPartitionValues() {
ImmutableList.of(row(4, Double.NEGATIVE_INFINITY)));
}
+ @TestTemplate
+ public void testFilterPushdownWithRequiredNestedFieldInOptionalStruct() {
Review Comment:
nit: Probably we don’t want to add this test to `TestFilterPushDown`, since
that suite is mainly for verifying whether filters are pushed down. In your
case, the filter `address.street is null` is already pushed down—the issue is
that it returns the wrong value (incorrectly false). I think it's probably
better to place the test in another suite, for example, `TestSelect`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
