guixiaowen commented on code in PR #13858: URL: https://github.com/apache/iceberg/pull/13858#discussion_r2285315064
########## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkUtil.java: ########## @@ -254,7 +255,7 @@ public static String toColumnName(NamedReference ref) { } public static boolean caseSensitive(SparkSession spark) { - return Boolean.parseBoolean(spark.conf().get("spark.sql.caseSensitive")); + return Boolean.parseBoolean(spark.conf().get(SqlApiConf.CASE_SENSITIVE_KEY())); Review Comment: > why not consistently use `SQLConf.CASE_SENSITIVE().key()` across all Spark versions? @nastra Thank you for your review. I have made the revisions as per your request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org