nastra commented on code in PR #13858:
URL: https://github.com/apache/iceberg/pull/13858#discussion_r2290375489


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##########
@@ -538,7 +539,7 @@ public static String describe(org.apache.iceberg.SortOrder 
order) {
   }
 
   public static boolean extensionsEnabled(SparkSession spark) {
-    String extensions = spark.conf().get("spark.sql.extensions", "");
+    String extensions = 
spark.conf().get(StaticSQLConf.SPARK_SESSION_EXTENSIONS().key(), "");

Review Comment:
   let's leave this change out, because there are more places across the 
codebase that use the hardcoded string which haven't been updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to