RussellSpitzer commented on code in PR #13137:
URL: https://github.com/apache/iceberg/pull/13137#discussion_r2286093278
##########
api/src/main/java/org/apache/iceberg/expressions/Literal.java:
##########
@@ -71,6 +72,10 @@ static Literal<BigDecimal> of(BigDecimal value) {
return new Literals.DecimalLiteral(value);
}
+ static Literal<Variant> of(Variant value) {
Review Comment:
Slightly worried about exposing this (even package private). No one should
ever be making a variant literal except for internal code. Do we need this
helper? The alternate I would suggest is just always explicitly creating the
VariantLiterals when you need to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
