RussellSpitzer commented on code in PR #13137:
URL: https://github.com/apache/iceberg/pull/13137#discussion_r2286104609
##########
api/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -107,6 +107,10 @@ private static byte metadataHeader(boolean isSorted, int
offsetSize) {
return (byte) (((offsetSize - 1) << 6) | (isSorted ? 0b10000 : 0) |
0b0001);
}
+ public static VariantValue value(VariantMetadata metadata, ByteBuffer value)
{
Review Comment:
Why do we need this helper? Doesn't look like it provides any value over
VariantValue.from which has the same signature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
