slfan1989 commented on code in PR #13795:
URL: https://github.com/apache/iceberg/pull/13795#discussion_r2286687439
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -66,6 +65,16 @@ public ZkLockFactory(
int maxRetries) {
Preconditions.checkNotNull(connectString, "Zookeeper connection string
cannot be null");
Preconditions.checkNotNull(lockId, "Lock ID cannot be null");
+ Preconditions.checkArgument(
+ sessionTimeoutMs > 0, "Session timeout must be positive, got: %s",
sessionTimeoutMs);
+ Preconditions.checkArgument(
+ connectionTimeoutMs > 0,
+ "Connection timeout must be positive, got: %s",
+ connectionTimeoutMs);
+ Preconditions.checkArgument(
+ baseSleepTimeMs > 0, "Base sleep time must be positive, got: %s",
baseSleepTimeMs);
Review Comment:
I have already made the modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
