slfan1989 commented on code in PR #13795:
URL: https://github.com/apache/iceberg/pull/13795#discussion_r2286689099
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestLockFactoryBase.java:
##########
@@ -30,6 +30,8 @@ abstract class TestLockFactoryBase {
abstract TriggerLockFactory lockFactory();
+ abstract TriggerLockFactory createOtherLockFactory(String tableName);
Review Comment:
This is a good suggestion! I have improved the original abstract methods by
unifying them into a single `abstract TriggerLockFactory lockFactory(String
tableName);`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
