nastra commented on code in PR #13837:
URL: https://github.com/apache/iceberg/pull/13837#discussion_r2290281341
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java:
##########
@@ -58,14 +60,19 @@ public class RewriteTablePathProcedure extends
BaseProcedure {
TARGET_PREFIX_PARAM,
START_VERSION_PARAM,
END_VERSION_PARM,
- STAGING_LOCATION_PARAM
+ STAGING_LOCATION_PARAM,
+ SKIP_FILE_LIST_PARAM
};
private static final StructType OUTPUT_TYPE =
new StructType(
new StructField[] {
new StructField("latest_version", DataTypes.StringType, true,
Metadata.empty()),
- new StructField("file_list_location", DataTypes.StringType, true,
Metadata.empty())
+ new StructField("file_list_location", DataTypes.StringType, true,
Metadata.empty()),
+ new StructField(
+ "rewrite_metadata_files_count", DataTypes.IntegerType, true,
Metadata.empty()),
Review Comment:
```suggestion
"rewritten_metadata_files_count", DataTypes.IntegerType,
true, Metadata.empty()),
```
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteTablePathProcedure.java:
##########
@@ -58,14 +60,19 @@ public class RewriteTablePathProcedure extends
BaseProcedure {
TARGET_PREFIX_PARAM,
START_VERSION_PARAM,
END_VERSION_PARM,
- STAGING_LOCATION_PARAM
+ STAGING_LOCATION_PARAM,
+ SKIP_FILE_LIST_PARAM
};
private static final StructType OUTPUT_TYPE =
new StructType(
new StructField[] {
new StructField("latest_version", DataTypes.StringType, true,
Metadata.empty()),
- new StructField("file_list_location", DataTypes.StringType, true,
Metadata.empty())
+ new StructField("file_list_location", DataTypes.StringType, true,
Metadata.empty()),
+ new StructField(
+ "rewrite_metadata_files_count", DataTypes.IntegerType, true,
Metadata.empty()),
+ new StructField(
+ "rewrite_delete_files_count", DataTypes.IntegerType, true,
Metadata.empty())
Review Comment:
```suggestion
"rewritten_delete_files_count", DataTypes.IntegerType, true,
Metadata.empty())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
