slfan1989 commented on code in PR #13837:
URL: https://github.com/apache/iceberg/pull/13837#discussion_r2290607582
##########
api/src/main/java/org/apache/iceberg/actions/RewriteTablePath.java:
##########
@@ -86,6 +86,16 @@ public interface RewriteTablePath extends
Action<RewriteTablePath, RewriteTableP
*/
RewriteTablePath stagingLocation(String stagingLocation);
+ /**
+ * Whether to skip saving the file list location.
+ *
+ * @param skipFileList true to skip saving the file list, false to include it
+ * @return this instance for method chaining
+ */
+ default RewriteTablePath skipFileList(boolean skipFileList) {
Review Comment:
Thank you for your question! `RewriteTablePathProcedure` generates a CSV
file, which is saved by default in the target directory. In #12762, I proposed
a new migration approach that allows upgrading Hive tables to Iceberg tables in
place. Using this method, we have already upgraded more than 2,000 tables.
Currently, after each migration, a `file-list.csv` file is created in the
table’s `metadata` directory. Since this file is not actually part of the
metadata, we need to clean it up manually. I suggest adding a parameter to the
procedure so that when it is invoked, we can choose not to generate this file,
thereby simplifying the migration process.
I think calling it createFileList is reasonable, and I will optimize this
part accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
