xixipi-lining commented on PR #542:
URL: https://github.com/apache/iceberg-go/pull/542#issuecomment-3212943297
Hi @zeroshade, thank you for your response. I'm new to Iceberg, so I'm not
very familiar with the previous implementation, but I've reviewed the commit
history of the catalog of iceberg-python. From the very first commit of the
catalog abstract class, the `load_table` interface has been:
```python
@abstractmethod
def load_table(self, identifier: Union[str, Identifier]) -> Table:
"""Loads the table's metadata and returns the table instance.
You can also use this method to check for table existence using 'try
catalog.table() except TableNotFoundError'
Note: This method doesn't scan data stored in the table.
Args:
identifier: Table identifier.
Returns:
Table: the table instance with its metadata
Raises:
TableNotFoundError: If a table with the name does not exist
"""
```
1. The first
[commit](https://github.com/apache/iceberg-python/commit/fae3a753a5a2c5576bc937c9df6d43d0ace0360d)
of catalog base with the definition of `load_table` in
[base.py#L80](https://github.com/apache/iceberg-python/blob/fae3a753a5a2c5576bc937c9df6d43d0ace0360d/src/iceberg/catalog/base.py#L80)
2. The first
[commit](https://github.com/apache/iceberg-python/commit/43e5b6c3ea65ab9f632b2fd30f6379f4ed98de39)
of rest catalog with the implementation of `load_table` in
[rest.py#L342](https://github.com/apache/iceberg-python/blob/43e5b6c3ea65ab9f632b2fd30f6379f4ed98de39/pyiceberg/catalog/rest.py#L342)
3. The first
[commit](https://github.com/apache/iceberg-python/commit/69e37c732c6336a8de37f6e64ccccad114d84dbf)
of hive catalog with the implementation of `load_table` in
[hive.py#L251](https://github.com/apache/iceberg-python/blob/69e37c732c6336a8de37f6e64ccccad114d84dbf/pyiceberg/catalog/hive.py#L251)
4. The first
[commit](https://github.com/apache/iceberg-python/commit/e1645abc82ded10488b51e4b8fc792fbd0d61118)
of glue catalog with the implementation of `load_table` in
[glue.py#L257](https://github.com/apache/iceberg-python/blob/e1645abc82ded10488b51e4b8fc792fbd0d61118/pyiceberg/catalog/glue.py#L257)
5. The first
[commit](https://github.com/apache/iceberg-python/commit/fd37e83cdf5a9243d88416202dfdd28fd7bb850f)
of dynamodb catalog with the implementation of `load_table` in
[dynamodb.py#L171](https://github.com/apache/iceberg-python/blob/fd37e83cdf5a9243d88416202dfdd28fd7bb850f/pyiceberg/catalog/dynamodb.py#L171)
6. The first
[commit](https://github.com/apache/iceberg-python/commit/be510c677a8e9ea99b2d7b10eb69260cf6f74a0c)
of sql catalog with the implementation of `load_table` in
[sql.py#L184](https://github.com/apache/iceberg-python/blob/be510c677a8e9ea99b2d7b10eb69260cf6f74a0c/pyiceberg/catalog/sql.py#L184)
Up to the current main branch catalog, the [load_table
interface](https://github.com/apache/iceberg-python/blob/5d6e1e212ed29dc1d5afb74eb628c02f556da9c2/pyiceberg/catalog/__init__.py#L430)
has remained largely unchanged, and the specific implementations also don't
have a `props` field:
[dynamodb](https://github.com/apache/iceberg-python/blob/5d6e1e212ed29dc1d5afb74eb628c02f556da9c2/pyiceberg/catalog/dynamodb.py#L249),
[glue](https://github.com/apache/iceberg-python/blob/5d6e1e212ed29dc1d5afb74eb628c02f556da9c2/pyiceberg/catalog/glue.py#L573),
[hive](https://github.com/apache/iceberg-python/blob/5d6e1e212ed29dc1d5afb74eb628c02f556da9c2/pyiceberg/catalog/hive.py#L597),
[sql](https://github.com/apache/iceberg-python/blob/5d6e1e212ed29dc1d5afb74eb628c02f556da9c2/pyiceberg/catalog/sql.py#L277).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
