xixipi-lining commented on code in PR #542:
URL: https://github.com/apache/iceberg-go/pull/542#discussion_r2292638142
##########
catalog/glue/glue.go:
##########
@@ -228,7 +224,7 @@ func (c *Catalog) LoadTable(ctx context.Context, identifier
table.Identifier, pr
ctx,
identifier,
location,
- io.LoadFSFunc(props, location),
+ io.LoadFSFunc(nil, location),
Review Comment:
I understand your concern. This is special for the glue catalog. The reason
we use nil here is because LoadFSFunc returns a `func(ctx context.Context) (IO,
error)`, while the actual IO-related props are recorded through the `awsCfg` in
the glue catalog, and we use `ctx = utils.WithAwsConfig(ctx, c.awsCfg)` to
regenerate a context for the function returned by LoadFSFunc to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
