RussellSpitzer commented on a change in pull request #1525: URL: https://github.com/apache/iceberg/pull/1525#discussion_r504299612
########## File path: spark/src/main/java/org/apache/iceberg/actions/CommonActions.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.actions; + +import org.apache.iceberg.Table; +import org.apache.spark.sql.SparkSession; + +public abstract class CommonActions { + + private SparkSession spark; + private Table table; + + protected CommonActions(SparkSession spark, Table table) { Review comment: This change has the unfortunate consequence that there is now an Actions in both Spark2 and Spark3 modules, which means that our abstract tests which use both have to delegate their "Actions.forTable" method to their implementations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
