openinx commented on a change in pull request #1586:
URL: https://github.com/apache/iceberg/pull/1586#discussion_r504450286



##########
File path: flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java
##########
@@ -53,4 +64,36 @@ public static void stopMetastore() {
     flinkCatalogs.values().forEach(Catalog::close);
     flinkCatalogs.clear();
   }
+
+  protected TableEnvironment getTableEnv() {

Review comment:
       Moving those tow method inside this super class, because the newly 
introduced unit test `TestFlinkHiveCatalog`  would use them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to