pvary opened a new pull request #1612: URL: https://github.com/apache/iceberg/pull/1612
As discussed on #1495 we should create the table specification from the columns in the table creation command. This PR does this. Here are the changes: - Create the Iceberg schema using the `serDeProperties` - Create the Iceberg partitioning specification using the partition columns defined in the `CREATE TABLE` command - Added tests which are reading the tables after creating them. Changes which are worth to double check: - If we are creating a Hive table with `CRATE TABLE ... PARTITIONED BY` command, then the resulting Iceberg table will be partitioned with identity partitions, but the Hive table itself will not be partitioned. This was needed since the read path is working with partitioned tables, and I do not see any good way to solve this since Hive wants to read the partitions one-by-one - The HadoopCatalog prevented setting the location when creating a new Iceberg table. Changed to allow calling `withLocation` if the provided location is set to `defaultLocation`, so I do not have to branch the code in Catalogs. - Only `HiveCatalog` will be using the default table location in Hive. When using other Catalogs the `LOCATION` should be provided in the `CREATE TABLE` command. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
