ebyhr commented on code in PR #13922:
URL: https://github.com/apache/iceberg/pull/13922#discussion_r2302848440
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestPartitionedWrites.java:
##########
@@ -18,4 +18,27 @@
*/
package org.apache.iceberg.spark.sql;
-public class TestPartitionedWrites extends PartitionedWritesTestBase {}
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
+
+import org.apache.iceberg.SnapshotSummary;
+import org.apache.iceberg.Table;
+import org.junit.jupiter.api.TestTemplate;
+
+public class TestPartitionedWrites extends PartitionedWritesTestBase {
+ @TestTemplate
+ public void testWapPropertiesNotSet() {
+ assertThatCode(
+ () -> {
+ sql("INSERT INTO %s VALUES (4, 'd')", tableName);
+ Table table = validationCatalog.loadTable(tableIdent);
+ assertThat(
+ table
+ .snapshot(table.refs().get("main").snapshotId())
+ .summary()
+ .get(SnapshotSummary.WAP_BRANCH_PROP))
+ .isNull();
Review Comment:
We should use `AbstractMapAssert`'s methods for better failure messages:
```java
assertThat(table.snapshot(table.refs().get("main").snapshotId()).summary())
.doesNotContainKey(SnapshotSummary.WAP_BRANCH_PROP);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
