huaxingao commented on code in PR #13922: URL: https://github.com/apache/iceberg/pull/13922#discussion_r2312252899
########## spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java: ########## @@ -114,6 +114,7 @@ class SparkPositionDeltaWrite implements DeltaWrite, RequiresDistributionAndOrde private final SparkWriteRequirements writeRequirements; private final Context context; private final Map<String, String> writeProperties; + private final boolean isWapBranch; Review Comment: Do we need this to be an instance variable? It seems only used in `commitOperation`; a local boolean `(writeConf.isWapBranch(branch))` would avoid extra state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
