HeartLinked commented on code in PR #194:
URL: https://github.com/apache/iceberg-cpp/pull/194#discussion_r2303117287
##########
src/iceberg/type.h:
##########
@@ -78,20 +79,23 @@ class ICEBERG_EXPORT NestedType : public Type {
/// \brief Get a field by field ID.
///
/// \note This is O(1) complexity.
- [[nodiscard]] virtual std::optional<std::reference_wrapper<const
SchemaField>>
+ [[nodiscard]] virtual Result<std::optional<std::reference_wrapper<const
SchemaField>>>
GetFieldById(int32_t field_id) const = 0;
/// \brief Get a field by index.
///
/// \note This is O(1) complexity.
- [[nodiscard]] virtual std::optional<std::reference_wrapper<const
SchemaField>>
+ [[nodiscard]] virtual Result<std::optional<std::reference_wrapper<const
SchemaField>>>
GetFieldByIndex(int32_t index) const = 0;
- /// \brief Get a field by name (case-sensitive). Behavior is undefined if
+ /// \brief Get a field by name. Behavior is not allowed if
Review Comment:
```suggestion
/// \brief Get a field by name. Returns an error Status if
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
