RussellSpitzer commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2304799535
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetVectorizedReads.java:
##########
@@ -336,4 +345,15 @@ public void testUuidReads() throws Exception {
}
assertRecordsMatch(schema, numRows, data, dataFile.toInputFile(), false,
BATCH_SIZE);
}
+
+ protected void assertNoLeak(String testName, Consumer<BufferAllocator>
testFunction) {
Review Comment:
The Instrumentation we are using, note that we actually close the child
allocator here which we don't do in our production code path. Maybe worth
considering as I mentioned but this would be a much bigger refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
