stevenzwu commented on code in PR #13935:
URL: https://github.com/apache/iceberg/pull/13935#discussion_r2305497578
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -142,6 +142,9 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
if (reuse == null
|| (!dictEncoded && readType == ReadType.DICTIONARY)
|| (dictEncoded && readType != ReadType.DICTIONARY)) {
+ if (vec != null) {
Review Comment:
if we close the vec in each of the 3 leaf allocate methods, we don't need to
do it here, right? It is is easier to follow the logic that way.
<img width="577" height="187" alt="image"
src="https://github.com/user-attachments/assets/77178846-6a42-421d-9179-782f4c8cfe59";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
