nullccxsy commented on code in PR #194:
URL: https://github.com/apache/iceberg-cpp/pull/194#discussion_r2306105655
##########
src/iceberg/type.h:
##########
@@ -67,6 +68,7 @@ class ICEBERG_EXPORT PrimitiveType : public Type {
bool is_nested() const override { return false; }
};
+using SchemaFieldConstRef = std::reference_wrapper<const SchemaField>;
Review Comment:
if do this, in type.cc, we should use NestedType::ScheamFieldConstRef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
