danielcweeks commented on pull request #1573: URL: https://github.com/apache/iceberg/pull/1573#issuecomment-709451096
@jackye1995 Sorry, my comment about S3Mock wasn't that it was not supported with v2, but rather the [docs for S3Mock say](https://github.com/adobe/S3Mock#using-the-junit5-extension) integration exists with JUnit4 with v1 and JUnit5 with v1 and v2. I didn't mean to imply that it didn't work, more that the current unit tests need to be updated to either use S3Mock like your example or switch to JUnit5 and use the extensions. I might be able to use a combination of the JUnit4 Rule with a custom client configured as well. It's not a big change overall, but I was also interested as to whether there was something provided by the sdkv2 that provides something similar to s3mock for testing. Thanks for the example, I'll give that a shot and see if I can keep the existing JUnit4 tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
