rdblue commented on a change in pull request #1573: URL: https://github.com/apache/iceberg/pull/1573#discussion_r511184731
########## File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws.s3; + +import com.amazonaws.services.s3.AmazonS3URI; +import java.io.IOException; +import java.io.Serializable; +import java.util.Objects; +import org.apache.http.HttpStatus; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.io.PositionOutputStream; +import org.apache.iceberg.io.SeekableInputStream; +import org.apache.iceberg.util.SerializableSupplier; +import software.amazon.awssdk.services.s3.S3Client; +import software.amazon.awssdk.services.s3.model.Delete; +import software.amazon.awssdk.services.s3.model.DeleteObjectsRequest; +import software.amazon.awssdk.services.s3.model.HeadObjectRequest; +import software.amazon.awssdk.services.s3.model.HeadObjectResponse; +import software.amazon.awssdk.services.s3.model.ObjectIdentifier; +import software.amazon.awssdk.services.s3.model.S3Exception; + +/** + * FileIO implementation backed by S3. Locations used must follow the conventions for URIs (e.g. s3://bucket/path/..). + */ +public class S3FileIO implements FileIO, Serializable { + private final SerializableSupplier<S3Client> s3; + private transient S3Client client; + + public S3FileIO(SerializableSupplier<S3Client> s3) { + this.s3 = s3; + } + + @Override + public InputFile newInputFile(String path) { + return new S3InputFile(new AmazonS3URI(path)); + } + + @Override + public OutputFile newOutputFile(String path) { + return new S3OutputFile(new AmazonS3URI(path)); + } + + @Override + public void deleteFile(String path) { + AmazonS3URI location = new AmazonS3URI(path); + client().deleteObjects(DeleteObjectsRequest.builder() + .bucket(location.getBucket()) + .delete(Delete.builder() + .objects(ObjectIdentifier.builder() + .key(location.getKey()) + .build()) + .build()) + .build()); + } + + private S3Client client() { + if (client == null) { + client = s3.get(); + } + return client; + } + + public class S3InputFile implements InputFile { + private final AmazonS3URI location; + private HeadObjectResponse metadata; + + public S3InputFile(AmazonS3URI location) { + this.location = location; + } + + /** + * Note: this may be stale if file was deleted since metadata is cached for size/existence checks. + * + * @return content length + */ + @Override + public long getLength() { + return Objects.requireNonNull(getObjectMetadata()).contentLength(); Review comment: This is going to throw a `NullPointerException` if the object doesn't exist because `getObjectMetadata` returns null when it receives a 404. I think it would be better for `getObjectMetadata` to throw `NotFoundException` with a friendly error message that includes the location. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
