HuaHuaY commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2322681473
##########
src/iceberg/table_metadata.h:
##########
@@ -145,7 +145,7 @@ ICEBERG_EXPORT std::string ToString(const SnapshotLogEntry&
entry);
ICEBERG_EXPORT std::string ToString(const MetadataLogEntry& entry);
/// \brief The codec type of the table metadata file.
-ICEBERG_EXPORT enum class MetadataFileCodecType {
+enum class ICEBERG_EXPORT MetadataFileCodecType {
Review Comment:
In file included from
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/catalog/in_memory_catalog.cc:27:
[383](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:384)
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/table_metadata.h:148:27:
error: attribute ignored in declaration of ‘enum class
iceberg::MetadataFileCodecType’ [-Werror=attributes]
[384](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:385)
148 | ICEBERG_EXPORT enum class MetadataFileCodecType {
[385](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:386)
| ^~~~~~~~~~~~~~~~~~~~~
[386](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:387)
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/table_metadata.h:148:27:
note: attribute for ‘enum class iceberg::MetadataFileCodecType’ must follow the
‘enum class’ keyword
##########
src/iceberg/table_metadata.h:
##########
@@ -145,7 +145,7 @@ ICEBERG_EXPORT std::string ToString(const SnapshotLogEntry&
entry);
ICEBERG_EXPORT std::string ToString(const MetadataLogEntry& entry);
/// \brief The codec type of the table metadata file.
-ICEBERG_EXPORT enum class MetadataFileCodecType {
+enum class ICEBERG_EXPORT MetadataFileCodecType {
Review Comment:
```sh
In file included from
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/catalog/in_memory_catalog.cc:27:
[383](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:384)
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/table_metadata.h:148:27:
error: attribute ignored in declaration of ‘enum class
iceberg::MetadataFileCodecType’ [-Werror=attributes]
[384](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:385)
148 | ICEBERG_EXPORT enum class MetadataFileCodecType {
[385](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:386)
| ^~~~~~~~~~~~~~~~~~~~~
[386](https://github.com/apache/iceberg-cpp/actions/runs/17465341036/job/49599584557?pr=211#step:3:387)
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/table_metadata.h:148:27:
note: attribute for ‘enum class iceberg::MetadataFileCodecType’ must follow the
‘enum class’ keyword
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
