zhjwpku commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2322362031
##########
src/iceberg/transform.h:
##########
@@ -56,8 +57,40 @@ enum class TransformType {
kVoid,
};
+constexpr std::string_view kUnknownName = "unknown";
Review Comment:
Why move these constants to the header file? I don't see the point :(
##########
src/iceberg/table_metadata.h:
##########
@@ -87,11 +87,11 @@ struct ICEBERG_EXPORT TableMetadata {
/// The highest assigned column ID for the table
int32_t last_column_id;
/// A list of schemas
- std::vector<std::shared_ptr<Schema>> schemas;
Review Comment:
I don't think this is necessary since we are inside a iceberg namespace
here, same for the below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
