jasonf20 commented on PR #13987:
URL: https://github.com/apache/iceberg/pull/13987#issuecomment-3263593994
Committing sets `shouldRefresh` to `true` and then `currentSnapshot` will
call refresh. It's implementations specific of course and the Rest catalog will
behave differently. RestTableOperations does not do this.
BaseMetastoreTableOperations on the other hand does:
```java
@Override
public TableMetadata current() {
if (shouldRefresh) {
return refresh();
}
return currentMetadata;
}
```
Regarding operations that update the Metadata, I think it's fine to return
the TableMetadata instead of a snapshot in that case. We can decide about the
specific handling of those.
The use case I care about specifically is tracking the new snapshot id
without additional network calls. In general there can be many reasons for
wanting the commit to return the updated state and I don't see any downsides to
doing so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
