twuebi commented on code in PR #558: URL: https://github.com/apache/iceberg-go/pull/558#discussion_r2331209855
########## partitions.go: ########## @@ -30,6 +31,7 @@ import ( const ( PartitionDataIDStart = 1000 InitialPartitionSpecID = 0 + unassignedFieldID = 0 Review Comment: field-ids semantic space starts at 1000, so 0 for unassigned is fine? Can also change to -1 if preferred -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org