twuebi commented on code in PR #558:
URL: https://github.com/apache/iceberg-go/pull/558#discussion_r2334547108


##########
table/updates.go:
##########
@@ -553,20 +553,22 @@ func (u *removeSnapshotRefUpdate) Apply(builder 
*MetadataBuilder) error {
 
 type removeSpecUpdate struct {
        baseUpdate
-       SpecIds []int64 `json:"spec-ids"`
+       SpecIds []int `json:"spec-ids"`

Review Comment:
   java uses `int` which is signed 32bit, rust uses `i32`, I think for cross 
language compatibility's sake it makes sense to keep it 32bit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to