stevenzwu commented on code in PR #14040: URL: https://github.com/apache/iceberg/pull/14040#discussion_r2335144289
########## parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java: ########## @@ -75,6 +78,16 @@ protected ParquetValueReader<T> createReader( } } + /** + * This method can be overridden to provide a custom implementation which also uses the fieldId of + * the Schema when creating the struct reader + */ + protected ParquetValueReader<T> createStructReader( Review Comment: A little weird that revapi complains about API change for non-public class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org