huaxingao commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2338001336
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -53,6 +53,9 @@
import org.apache.parquet.schema.Type;
abstract class BaseParquetReaders<T> {
+ // Root ID is used for the top-level struct in the Parquet Schema
+ protected static final int ROOT_ID = 1;
Review Comment:
+1 to use `-1` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
