wypoon commented on code in PR #14045: URL: https://github.com/apache/iceberg/pull/14045#discussion_r2337991134
########## format/spec.md: ########## @@ -1861,6 +1861,10 @@ Java writes `-1` for "no current snapshot" with V1 and V2 tables and considers t Some implementations require that GZIP compressed files have the suffix `.gz.metadata.json` to be read correctly. The Java reference implementation can additionally read GZIP compressed files with the suffix `metadata.json.gz`. +### Position Delete Files with Row Data + +The feature allowing position delete files to include row data, which was introduced in the V2 Iceberg specification, is now deprecated in V3. The Java reference implementation will deprecate this feature in version 1.11.0 and remove it in version 1.12.0, including for V2 tables. Other implementations are encouraged to follow the same deprecation and removal schedule. Review Comment: Here is what I suggest for this section: "Although the spec allows for including the deleted row itself (in addition to the path and position of the row in the data file) in v2 position delete files, writing the row is optional and no implementation currently writes it. The ability to write and read the row is supported in the Java implementation but is deprecated in version 1.11.0." In PositionDelete.java, the deprecated methods have the comment "is deprecated in version 1.11.0", so we keep the same tense here. If other implementations do not even support writing/reading the deleted row, do we even need to say anything about them (in particular, that they should not do so in the future)? This appendix is "Implementation Notes", after all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
