amogh-jahagirdar commented on code in PR #14045: URL: https://github.com/apache/iceberg/pull/14045#discussion_r2337980593
########## format/spec.md: ########## @@ -1861,6 +1861,10 @@ Java writes `-1` for "no current snapshot" with V1 and V2 tables and considers t Some implementations require that GZIP compressed files have the suffix `.gz.metadata.json` to be read correctly. The Java reference implementation can additionally read GZIP compressed files with the suffix `metadata.json.gz`. +### Position Delete Files with Row Data + +The feature allowing position delete files to include row data, which was introduced in the V2 Iceberg specification, is now deprecated in V3. The Java reference implementation will deprecate this feature in version 1.11.0 and remove it in version 1.12.0, including for V2 tables. Other implementations are encouraged to follow the same deprecation and removal schedule. Review Comment: I'm OK either way but I lean towards mentioning it in the implementation notes (as done here) just because it was technically a capability enabled in the spec and even though we do not know of any writers actually producing the row data, on the offhand that some unknown implementation did produce it and wants to later use the Java library with the expectation to consume that, they can reference this historical context. In terms of spec wording, I think I'd remove "Other implementations are encouraged to adopt the same deprecation and removal timeline" because I'm not sure it changes much. If in the slim chance an unknown implementation cares about producing position deletes with row data for whatever reason then they probably also want to consume it (for whatever reason)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
