kbendick commented on a change in pull request #1636:
URL: https://github.com/apache/iceberg/pull/1636#discussion_r508113462
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcWriters.java
##########
@@ -285,8 +296,10 @@ public void nonNullWrite(int rowId, MapData data,
ColumnVector output) {
// record the length and start of the list elements
cv.lengths[rowId] = data.size();
cv.offsets[rowId] = cv.childCount;
- cv.childCount += cv.lengths[rowId];
+ cv.childCount += data.size();
// make sure the child is big enough
+ // TODO - Should this be done before adding to childCount in case of
overflow?
+ // - Possibly we could sum up the values of `cv.length` if we're
really worried about overflow?
Review comment:
Again, this TODO is not needed but I'd rather not trigger CI, which it
seems drafts do get run (at least initially). I may need to learn Travis so I
can possibly help out with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
