kbendick commented on a change in pull request #1636:
URL: https://github.com/apache/iceberg/pull/1636#discussion_r508115113
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/data/FlinkOrcWriters.java
##########
@@ -245,8 +245,19 @@ public void nonNullWrite(int rowId, ArrayData data,
ColumnVector output) {
ListColumnVector cv = (ListColumnVector) output;
cv.lengths[rowId] = data.size();
cv.offsets[rowId] = cv.childCount;
- cv.childCount += cv.lengths[rowId];
+ // cv.childCount is for some reason an int, which generates all of these
+ // NarrowingCompoundAssignment warnings. Although this does nothing to
prevent
+ // overflow from adding too many values to cv.childCount because
`ListColumnVector`
+ // comes from package `org.apache.orc.storage.ql.exec.vector`, it at
least removes
Review comment:
As it is, my point is we can't necessarily change it to be a long unless
somebody on the orc side can do that (which I think this is a possible bug in
their interface given that the arrays `lengths` and `offsets` are both long
arrays but I've no idea the ramifications of that being changed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
