rdblue commented on a change in pull request #1586:
URL: https://github.com/apache/iceberg/pull/1586#discussion_r509462458
##########
File path: site/docs/flink.md
##########
@@ -97,7 +97,21 @@ CREATE CATALOG hive_catalog WITH (
'catalog-type'='hive',
'uri'='thrift://localhost:9083',
'clients'='5',
- 'property-version'='1'
+ 'property-version'='1',
+ 'hive-conf-dir'='/opt/hive/conf'
+);
+```
+
+Alternatively one can instead set just the `warehouse` property (without
specifying a Hive configuration directory) to initialize the Hive catalog:
Review comment:
A small clarification: this implies that the use of `hive-site.xml` and
`warehouse` are alternatives, but they aren't. You may want to use `warehouse`
from the Hive site, or you may want to use other settings from `hive-site.xml`
with a custom warehouse location. I think this should document the two options
separately.
For documenting options, I think we will want to add a table because copying
the SQL block each time creates a long doc. I would have one simple example for
each catalog type with the options we recommend for it (Hive: uri, warehouse,
and property-version; Hadoop: warehouse, property-version) and a table of other
options for the Hive catalog to document `clients` and `hive-conf-dir`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
