rdblue commented on pull request #1586: URL: https://github.com/apache/iceberg/pull/1586#issuecomment-713729137
Thanks, @openinx! Mostly minor comments, except for the number of threads for the Hive MetaStore. We're very careful about changing that value so I'd like to understand your reason for changing it. I think the implementation here addresses my concerns from the discussion on #1558. I understand not being able to add files to the classpath easily, and I like that this makes it simple to add a config directory. That's a reasonable thing to support, although it would be nice if users didn't need to specify it each time they create a catalog. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
