liurenjie1024 commented on code in PR #1693:
URL: https://github.com/apache/iceberg-rust/pull/1693#discussion_r2367422955
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -23,10 +23,25 @@ on:
- main
pull_request:
paths:
- - ".github/workflows/bindings_python_ci.yml"
- - "bindings/python/**"
- - "crates/iceberg/**"
- - "crates/integrations/datafusion/**"
+ - '**' # Include all files and
directories in the repository by default.
+ - '!.github/workflows/**' # Exclude all workflow files
+ - '.github/workflows/bindings_python_ci.yml' # except the current file.
+ - '!.github/actions/**' # Exclude custom actions
Review Comment:
Same as above.
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -23,10 +23,25 @@ on:
- main
pull_request:
paths:
- - ".github/workflows/bindings_python_ci.yml"
- - "bindings/python/**"
- - "crates/iceberg/**"
- - "crates/integrations/datafusion/**"
+ - '**' # Include all files and
directories in the repository by default.
+ - '!.github/workflows/**' # Exclude all workflow files
Review Comment:
Is this safe? I don't think we should exclude workflow files.
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -23,10 +23,25 @@ on:
- main
pull_request:
paths:
- - ".github/workflows/bindings_python_ci.yml"
- - "bindings/python/**"
- - "crates/iceberg/**"
- - "crates/integrations/datafusion/**"
+ - '**' # Include all files and
directories in the repository by default.
+ - '!.github/workflows/**' # Exclude all workflow files
+ - '.github/workflows/bindings_python_ci.yml' # except the current file.
+ - '!.github/actions/**' # Exclude custom actions
+ - 'bindings/python/**' # Include source codes and
its dependencies
+ - '!crates/**'
Review Comment:
I don't think we should exclude this.
##########
.github/workflows/ci.yml:
##########
@@ -22,7 +22,7 @@ on:
branches:
- main
pull_request:
- branches:
+ paths:
- '**' # Include all files and directories
in the repository by default.
- '!.github/workflows/**' # Exclude all workflow files
Review Comment:
Same as python ci, please restore workflows, actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
