liurenjie1024 commented on code in PR #1693:
URL: https://github.com/apache/iceberg-rust/pull/1693#discussion_r2377834085
##########
.github/workflows/bindings_python_ci.yml:
##########
@@ -23,10 +23,25 @@ on:
- main
pull_request:
paths:
- - ".github/workflows/bindings_python_ci.yml"
- - "bindings/python/**"
- - "crates/iceberg/**"
- - "crates/integrations/datafusion/**"
+ - '**' # Include all files and
directories in the repository by default.
+ - '!.github/workflows/**' # Exclude all workflow files
+ - '.github/workflows/bindings_python_ci.yml' # except the current file.
+ - '!.github/actions/**' # Exclude custom actions
+ - 'bindings/python/**' # Include source codes and
its dependencies
+ - '!crates/**'
Review Comment:
What I want to say is that we should not only focus on current status. For
example, what if we added another crate and python binding relies on it, and
the ci may not be triggerred. Yes you could argue that this could be resolved
eventually, but it would be confusing for new contributor to see that ci can't
detect the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
