jbonofre commented on code in PR #243: URL: https://github.com/apache/iceberg-cpp/pull/243#discussion_r2374319971
########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ -------------------------------------------------------------------------------- -The file src/iceberg/util/checked_cast.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/checked_cast.h - -The file src/iceberg/util/visit_type.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h +This product includes code from Apache Arrow. -The file src/iceberg/util/decimal.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h - -The file src/iceberg/util/decimal.cc contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc +* checked_cast utility in src/iceberg/util/checked_cast.h. +* visit_type utility in src/iceberg/util/visit_type.h. +* Decimal128 implementation details in src/iceberg/util/decimal files. Copyright: 2016-2025 The Apache Software Foundation. Home page: https://arrow.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -3rdparty dependency spdlog is statically linked in certain binary -distributions. spdlog has the following license: - -MIT License +This product bundles spdlog. -Copyright (c) 2016 Gabi Melman +* Used for structured logging functionality. -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: 2016 Gabi Melman. +Home page: https://github.com/gabime/spdlog +License: https://mit-license.org/ Review Comment: The MIT license content should be copied in-line here. ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ -------------------------------------------------------------------------------- -The file src/iceberg/util/checked_cast.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/checked_cast.h - -The file src/iceberg/util/visit_type.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h +This product includes code from Apache Arrow. -The file src/iceberg/util/decimal.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h - -The file src/iceberg/util/decimal.cc contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc +* checked_cast utility in src/iceberg/util/checked_cast.h. +* visit_type utility in src/iceberg/util/visit_type.h. +* Decimal128 implementation details in src/iceberg/util/decimal files. Copyright: 2016-2025 The Apache Software Foundation. Home page: https://arrow.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -3rdparty dependency spdlog is statically linked in certain binary -distributions. spdlog has the following license: - -MIT License +This product bundles spdlog. -Copyright (c) 2016 Gabi Melman +* Used for structured logging functionality. -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: 2016 Gabi Melman. +Home page: https://github.com/gabime/spdlog +License: https://mit-license.org/ -------------------------------------------------------------------------------- -3rdparty dependency zlib is used by certain binary distributions. zlib has -the following license: +This product bundles zlib. Review Comment: Same question here: is it code copy or binary bundle ? ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. Review Comment: By bundle, does it mean code copy or binary (so files for instance) shipped in the binary package. The `LICENSE` here is for source distribution, so we should only mention code copied from other projects (not binary artifact bundles in the binary distribution). If we distribute a binary artifact, I recommend to use a `LICENSE` file dedicated for the binary distribution. ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ -------------------------------------------------------------------------------- -The file src/iceberg/util/checked_cast.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/checked_cast.h - -The file src/iceberg/util/visit_type.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h +This product includes code from Apache Arrow. -The file src/iceberg/util/decimal.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h - -The file src/iceberg/util/decimal.cc contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc +* checked_cast utility in src/iceberg/util/checked_cast.h. +* visit_type utility in src/iceberg/util/visit_type.h. +* Decimal128 implementation details in src/iceberg/util/decimal files. Copyright: 2016-2025 The Apache Software Foundation. Home page: https://arrow.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -3rdparty dependency spdlog is statically linked in certain binary -distributions. spdlog has the following license: - -MIT License +This product bundles spdlog. Review Comment: Same question: is it code copy or binary bundle ? ########## NOTICE: ########## @@ -3,22 +3,3 @@ Copyright 2024-2025 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). Review Comment: This is correct. The `NOTICE` file should only contains the `NOTICE` of Apache licensed projects where the code has been copied (`NOTICE` should not be used for other license types), if provided, and only the relevant part of our project. In the case of ASF projects (like Apache Arrow), it's not needed to copy `NOTICE` file as it's already covered by `This product includes software developed at The Apache Software Foundation (http://www.apache.org/)`. ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ Review Comment: MIT license content should be copied here inline. ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ -------------------------------------------------------------------------------- -The file src/iceberg/util/checked_cast.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/checked_cast.h - -The file src/iceberg/util/visit_type.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h +This product includes code from Apache Arrow. -The file src/iceberg/util/decimal.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h - -The file src/iceberg/util/decimal.cc contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc +* checked_cast utility in src/iceberg/util/checked_cast.h. +* visit_type utility in src/iceberg/util/visit_type.h. +* Decimal128 implementation details in src/iceberg/util/decimal files. Copyright: 2016-2025 The Apache Software Foundation. Home page: https://arrow.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -3rdparty dependency spdlog is statically linked in certain binary -distributions. spdlog has the following license: - -MIT License +This product bundles spdlog. -Copyright (c) 2016 Gabi Melman +* Used for structured logging functionality. -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: 2016 Gabi Melman. +Home page: https://github.com/gabime/spdlog +License: https://mit-license.org/ -------------------------------------------------------------------------------- -3rdparty dependency zlib is used by certain binary distributions. zlib has -the following license: +This product bundles zlib. -zlib License +* gzip compression/decompression functionality in src/iceberg/util/gzip_internal.cc -Copyright (c) 1995-2024 Jean-loup Gailly and Mark Adler +Copyright: 1995-2024 Jean-loup Gailly and Mark Adler. +Home page: https://zlib.net/ +License: https://www.zlib.net/zlib_license.html Review Comment: This license looks pretty close to MIT/BSD one. So I would sugest to copy the license content inline. ########## LICENSE: ########## @@ -202,117 +202,63 @@ -------------------------------------------------------------------------------- -3rdparty dependency nlohmann-json is statically linked in certain binary -distributions. nlohmann-json has the following license: +This product includes code from smhasher. -MIT License +* src/iceberg/murmur3_internal.h and src/iceberg/murmur3_internal.cc are adapted from MurmurHash3. -Copyright (c) 2013-2022 Niels Lohmann - -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: Austin Appleby (placed in the public domain). +Home page: https://github.com/aappleby/smhasher +License: Public Domain -------------------------------------------------------------------------------- -The file src/iceberg/murmur3_internal.h contains code adapted from - -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.h +This product bundles nlohmann-json. -The file src/iceberg/murmur3_internal.cc contains code adapted from +* JSON serialization/deserialization functionality in src/iceberg/json_internal.h and src/iceberg/json_internal.cc. +* Used throughout the codebase for Iceberg table metadata processing. -https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp - -MurmurHash3 was written by Austin Appleby, and is placed in the public -domain. The author disclaims copyright to this source code. +Copyright: 2013-2022 Niels Lohmann. +Home page: https://github.com/nlohmann/json +License: https://mit-license.org/ -------------------------------------------------------------------------------- -The file src/iceberg/util/checked_cast.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/checked_cast.h - -The file src/iceberg/util/visit_type.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/visit_type_inline.h +This product includes code from Apache Arrow. -The file src/iceberg/util/decimal.h contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.h - -The file src/iceberg/util/decimal.cc contains code adapted from - -https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/decimal.cc +* checked_cast utility in src/iceberg/util/checked_cast.h. +* visit_type utility in src/iceberg/util/visit_type.h. +* Decimal128 implementation details in src/iceberg/util/decimal files. Copyright: 2016-2025 The Apache Software Foundation. Home page: https://arrow.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -3rdparty dependency spdlog is statically linked in certain binary -distributions. spdlog has the following license: - -MIT License +This product bundles spdlog. -Copyright (c) 2016 Gabi Melman +* Used for structured logging functionality. -Permission is hereby granted, free of charge, to any person obtaining a copy -of this software and associated documentation files (the "Software"), to deal -in the Software without restriction, including without limitation the rights -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell -copies of the Software, and to permit persons to whom the Software is -furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all -copies or substantial portions of the Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. +Copyright: 2016 Gabi Melman. +Home page: https://github.com/gabime/spdlog +License: https://mit-license.org/ -------------------------------------------------------------------------------- -3rdparty dependency zlib is used by certain binary distributions. zlib has -the following license: +This product bundles zlib. -zlib License +* gzip compression/decompression functionality in src/iceberg/util/gzip_internal.cc -Copyright (c) 1995-2024 Jean-loup Gailly and Mark Adler +Copyright: 1995-2024 Jean-loup Gailly and Mark Adler. +Home page: https://zlib.net/ +License: https://www.zlib.net/zlib_license.html -This software is provided 'as-is', without any express or implied Review Comment: This is actually better: for non Apache license (BSD/MIT, etc), the license content should be in this `LICENSE` or in folder `licenses` containing 3rd party license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
