mdwint commented on code in PR #2429:
URL: https://github.com/apache/iceberg-python/pull/2429#discussion_r2375145318
##########
tests/table/test_upsert.py:
##########
@@ -440,6 +441,70 @@ def test_create_match_filter_single_condition() -> None:
)
[email protected](
+ "data, expected",
+ [
+ pytest.param(
+ [{"x": 1.0}, {"x": 2.0}, {"x": None}, {"x": 4.0}, {"x":
float("nan")}],
+ Or(
+ left=IsNull(term=Reference(name="x")),
+ right=Or(
+ left=IsNaN(term=Reference(name="x")),
+ right=In(Reference(name="x"), {DoubleLiteral(1.0),
DoubleLiteral(2.0), DoubleLiteral(4.0)}),
+ ),
+ ),
+ id="single-column",
+ ),
+ pytest.param(
+ [
+ {"x": 1.0, "y": 9.0},
+ {"x": 2.0, "y": None},
+ {"x": None, "y": 7.0},
+ {"x": 4.0, "y": float("nan")},
+ {"x": float("nan"), "y": 0.0},
+ ],
+ Or(
+ left=Or(
+ left=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(1.0)),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(9.0)),
+ ),
+ right=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(2.0)),
+ right=IsNull(term=Reference(name="y")),
+ ),
+ ),
+ right=Or(
+ left=And(
+ left=IsNull(term=Reference(name="x")),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(7.0)),
+ ),
+ right=Or(
+ left=And(
+ left=EqualTo(term=Reference(name="x"),
literal=DoubleLiteral(4.0)),
+ right=IsNaN(term=Reference(name="y")),
+ ),
+ right=And(
+ left=IsNaN(term=Reference(name="x")),
+ right=EqualTo(term=Reference(name="y"),
literal=DoubleLiteral(0.0)),
+ ),
+ ),
+ ),
+ ),
+ id="multi-column",
+ ),
+ ],
+)
+def test_create_match_filter_with_nulls(data: list[dict[str, Any]], expected:
BooleanExpression) -> None:
Review Comment:
This tests that the match filters produced for `data` are equal to
`expected`. I used parameters to make the test data-driven (not having to
duplicate the code for new cases). Would you prefer that I write them as
regular tests instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
