pvary commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2385230944
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -115,20 +115,32 @@ public WriteResult complete() throws IOException {
protected abstract class BaseEqualityDeltaWriter implements Closeable {
private final StructProjection structProjection;
private final PositionDelete<T> positionDelete;
+ private final StructLike partitionKey;
+ private final boolean useDv;
Review Comment:
Could we have 2 classes implementing the same interface? One of them is
using PosDelete writer, one the DV writer?
This is really just a question at this point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
