Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2439989811
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -129,24 +130,43 @@ public WriteResult complete() throws IOException {
.build();
}
+ protected void addReferencedDataFiles(CharSequenceSet files) {
+ referencedDataFiles.addAll(files);
+ }
+
+ protected void addCompletedDeleteFiles(List<DeleteFile> files) {
+ completedDeleteFiles.addAll(files);
+ }
+
Review Comment:
Yes, we need it. Since we share the dvWrite in `PartitionedDeltaWriter`, we
can only close once, then we can call these method to add`DeleteWriteResult` to
the`completedDeleteFiles` and `referencedDataFiles` in
`PartitionedDeltaWriter.close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
