pvary commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2388709350
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -68,7 +93,6 @@ protected BaseFileWriterFactory(
this.equalityFieldIds = equalityFieldIds;
this.equalityDeleteRowSchema = equalityDeleteRowSchema;
this.equalityDeleteSortOrder = equalityDeleteSortOrder;
- this.positionDeleteRowSchema = positionDeleteRowSchema;
Review Comment:
I have concerns here.
We silently change the behavior if we deprecate the position delete from
here too early.
There are 2 classes inheriting from it:
- FlinkFileWriterFactory - not used, and not exposed
- SparkFileWriterFactory - protected class itself, but the functionality is
exposed through 2 classes:
- SparkPositionDeletesRewrite - it is a public class in Spark to rewrite
delete files. So if an input position delete contains a row data, then we need
to be able to handle it until the deprecation.
- SparkPositionDeltaWrite - this one is fine, as we only write position
delete without row data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
