pvary commented on code in PR #14210:
URL: https://github.com/apache/iceberg/pull/14210#discussion_r2390935359
##########
data/src/main/java/org/apache/iceberg/data/BaseFileWriterFactory.java:
##########
@@ -50,6 +50,33 @@ public abstract class BaseFileWriterFactory<T> implements
FileWriterFactory<T> {
private final SortOrder equalityDeleteSortOrder;
private final Schema positionDeleteRowSchema;
+ protected BaseFileWriterFactory(
+ Table table,
+ FileFormat dataFileFormat,
+ Schema dataSchema,
+ SortOrder dataSortOrder,
+ FileFormat deleteFileFormat,
+ int[] equalityFieldIds,
+ Schema equalityDeleteRowSchema,
+ SortOrder equalityDeleteSortOrder) {
+ this.table = table;
+ this.dataFileFormat = dataFileFormat;
+ this.dataSchema = dataSchema;
+ this.dataSortOrder = dataSortOrder;
+ this.deleteFileFormat = deleteFileFormat;
+ this.equalityFieldIds = equalityFieldIds;
+ this.equalityDeleteRowSchema = equalityDeleteRowSchema;
+ this.equalityDeleteSortOrder = equalityDeleteSortOrder;
+ this.positionDeleteRowSchema = null;
+ }
+
+ /**
+ * @deprecated This constructor is deprecated as of version 1.11.0 and will
be removed in 1.12.0.
+ * Position deletes that include row data are no longer supported. Use
{@link
+ * #BaseFileWriterFactory(Table, FileFormat, Schema, SortOrder,
FileFormat, int[], Schema,
+ * SortOrder)} instead.
+ */
+ @Deprecated
Review Comment:
We need to keep this, as SparkFileWriterFactory inherits from this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
