yyanyy commented on a change in pull request #1641:
URL: https://github.com/apache/iceberg/pull/1641#discussion_r510491645
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java
##########
@@ -126,38 +126,39 @@ private SparkParquetWriters() {
@Override
public ParquetValueWriter<?> primitive(DataType sType, PrimitiveType
primitive) {
ColumnDescriptor desc = type.getColumnDescription(currentPath());
+ Type.ID id = primitive.getId();
Review comment:
This is used to create `FieldMetrics` for individual writer so that we
can later have a mapping between id and the new counter. Do you want me to add
a comment in the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
