jackye1995 commented on a change in pull request #1641:
URL: https://github.com/apache/iceberg/pull/1641#discussion_r517545259
##########
File path:
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFieldMetrics.java
##########
@@ -23,32 +23,44 @@
import org.apache.iceberg.FieldMetrics;
/**
- * TODO comments
+ * Iceberg internally tracked field level metrics, used by Parquet writer only.
+ * Parquet keeps track of most metrics in its footer, and only NaN counter is
actually tracked by writers. This
Review comment:
nit: start a sentence on a new line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
