amogh-jahagirdar commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2418045764
##########
api/src/main/java/org/apache/iceberg/ExpireSnapshots.java:
##########
@@ -119,6 +119,17 @@ public interface ExpireSnapshots extends
PendingUpdate<List<Snapshot>> {
*/
ExpireSnapshots cleanExpiredFiles(boolean clean);
+ /**
+ * Skip the cleanup of orphaned data files as part of snapshot expiration
+ *
+ * @param retain true to retain orphaned data files only reachable by
expired snapshots
+ * @return this for method chaining
+ */
+ default ExpireSnapshots retainOrphanedDataFiles(boolean retain) {
Review Comment:
I feel like this isn't necessary to achieve the behavior of "clean up the
metadata files but keep the data/delete files". There's a `deleteWith` API
which allows for custom functions to delete based on paths. A client could just
pass in a function which based on if a path is a path in the metadata location
clean it up, otherwise don't do anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
