Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2440000659
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/PartitionedDeltaWriter.java:
##########
@@ -28,17 +28,21 @@
import org.apache.iceberg.PartitionKey;
import org.apache.iceberg.PartitionSpec;
import org.apache.iceberg.Schema;
+import org.apache.iceberg.io.DeleteWriteResult;
import org.apache.iceberg.io.FileIO;
import org.apache.iceberg.io.FileWriterFactory;
import org.apache.iceberg.io.OutputFileFactory;
+import org.apache.iceberg.io.PartitioningDVWriter;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
import org.apache.iceberg.util.Tasks;
class PartitionedDeltaWriter extends BaseDeltaTaskWriter {
private final PartitionKey partitionKey;
-
+ private final OutputFileFactory fileFactory;
private final Map<PartitionKey, RowDataDeltaWriter> writers =
Maps.newHashMap();
+ private PartitioningDVWriter dvFileWriter;
+ private final boolean useDv;
Review Comment:
Yes, I think we need it, because we create `dvFileWriter` in
`PartitionedDeltaWriter.route` , we need useDv flag to decide weather to
create `dvFileWriter` or create null for use `positionDeleteWrite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
